njlr

Results 255 comments of njlr

Thanks, I was able to play around with it: ```fsharp #r "nuget: Thoth.Json.Core, 0.2.1" #r "nuget: Thoth.Json.Newtonsoft, 0.1.0" open Thoth.Json.Core type Book = { Title : string Year : int...

Maybe I hit a bug? ```fsharp #r "nuget: Thoth.Json.Core, 0.2.1" #r "nuget: Thoth.Json.Newtonsoft, 0.1.0" open Thoth.Json.Core open Thoth.Json.Newtonsoft let json = Encode.int16 -7s |> Encode.toString 0 printfn $"%s{json}" // 4294967289...

I have tidied up the auto code I have and ported it to `Thoth.Json.Core`: https://github.com/njlr/thoth-json-auto It largely unifies Fable and .NET, aside from cases where Fable's reflection capabilities are limited...

Perhaps this is a good time to make a breaking change? ```fsharp #r "nuget: System.Text.Json, 8.0.3" open System.Text.Json let json = JsonSerializer.Serialize(-7s) printfn $"%s{json}" // -7 ``` I don't think...

> Oh you mean, I made a mistakes by converting a `int16` into an `unsigned int` which don't accept negative values? > > Depends on what you mean by breaking...

I wonder if `Encoder = 'T -> Json ``` _After:_ ```fsharp type IEncodable = abstract member Encode -> 'JsonValue type Encoder IEncodable // Probably won't work as-is, just a sketch...

> > I wonder if `Encoder > Sorry, I don't exactly remember the situation it was a few months ago. I think the trick is to have two types `Encoder`...

Here is an implementation of "Auto" that is agnostic to the JSON backend: https://github.com/thoth-org/Thoth.Json/pull/189

> @njlr Thank you I would make some time during this week to look at all the PRs you sent. > > The one reworking the manual API looked good...