njlr

Results 255 comments of njlr

There is an example showing how to do batching here: https://github.com/fsprojects/FSharp.Data.GraphQL/issues/255#issuecomment-1640617865 I'm unsure if batching belongs in this library, since `async` provides a powerful customization point already.

> @AndrewGuenther is this still an issue? I wasn't able to repro it and CI builds pass as well The CI has this test disabled: https://github.com/soniaai/rules_poetry/blob/master/test/BUILD#L36

Is it not possible to chain together `container_run_and_commit_layer` and `container_image`? For example ```starlark container_image( name = "stage_1", tars = [ ":app", ], ) container_run_and_commit_layer( name = "stage_2", image = ":stage_1.tar",...

> @njlr now we have > > ``` > The active test run was aborted. Reason: Test host process crashed : Stack overflow. > at System.ModuleHandle.ResolveMethod(System.Runtime.CompilerServices.QCallModule, Int32, IntPtr*, Int32, IntPtr*,...

> Yes, please Do you know the .NET type?

> No I managed to reproduce the issue with a recursive record definition. There is now a fix and a test for this.

> Perfect! Could you also rebase it on the latest dev, please? OK I think it's ready

Should add that this is an advantage of CMake over Buck right now.

This does not crash: ```fsharp #r "nuget: SharpCompress, 0.33.0" open SharpCompress open SharpCompress.Archives let archive = ArchiveFactory.Open("test.7z") for e in archive.Entries do if e.IsDirectory then printfn $"%A{e} is a directory"...

Curiously, this seems to work: ```diff container_image( name = "image", base = "@dotnet_runtime_deps_6_0_10//image", layers = [ - ":install_git", ], + tars = [ + ":install_git", + ], ) ```