Niels de Vos

Results 517 comments of Niels de Vos

> @nixpanic, I see `fscrypt.Unlock` call for RBD fscrypt. Do we need to do the same here as well? No, for RBD that is not needed. RBD with a filesystem...

Also don't forget to add the new annotation to the documentation!

As we had a meeting about this, it would be good to include a summary of the discussion in this PR. From what I remember, we want to _prevent users...

@black-dragon74 the annotations should be mentioned in the documentation too. Please add a paragraph about those.

> May I follow the documentation updates in a separate PR? My preference is to include a commit about it in this PR. There is a large chance it is...

@Rakshith-R please update this, or let me know if you want me to take it over. Thanks!

> _fyi: [ceph/ceph-csi#5220](https://github.com/ceph/ceph-csi/issues/5220)_ Thanks for the reference. That is just one implementation of a csi-driver with csi-addons support. Please included a description/design for the need of attributes, and what attributes...