Nitesh Sinha
Nitesh Sinha
@NoumbissiValere I don't have any idea of writing tests. But i will try to learn and understand it through the code after that i will add tests for it as...
I have added test for it. Please review it once again.
> @niteshsinha17 sorry I forgot to add my review last time I tested this, I didn't see the organization being selected automatically when the user had only one org, could...
@nemesisdesign Thanks for the review. > I've tested it again and found the issue. I tried to replicate this but it was not occurring in my system. During this, I...
@nemesisdesign It is ready for review. Do I need to resolve this conflict by rebasing??
Re-based to current master. Ready for review. I have one doubt. When org field is not required then we are setting ``empty label`` to ``Shared systemwide (no organization)``. but when...
> @niteshsinha17 may be the only organization should be selected when there is only one organization. 🤔 Actually, there is only one org but it looks like has 2 org...
@atb00ker I have made all the changes. Please check
> @niteshsinha17 the changes that you have made in this PR were not expected. > > Read this discussion to get a better idea of what is expected from the...
@pandafy from this https://github.com/openwisp/openwisp-notifications/pull/69#pullrequestreview-471188099 I have concluded a few things that I wanted to share with you. - I need to create that `All` setting which was removed in this...