nishitani yuki

Results 6 comments of nishitani yuki

Thanks for working on this. Still WIP??

In case HTTP request is not completed in 30 minutes, no need to retry, I think. How about setting timeout on `download`, not on HTTP request? https://github.com/cybozu-go/aptutil/pull/43/files#diff-65f38e03d73008242435b67f427bb10cR330 And putting these...

> I believe that you should set timeouts for individual connections. > Then the download will be retried properly and you will be able to recover from a temporary malfunction...

Sorry for the late reply. I'll take the time to review your PR in this week. Please wait a little longer 🙏

@takumin > The reason is that when the launchpad.net server is heavily loaded, timeouts occur frequently depending on the setting of MaxIdleConnsPerHost. Can you share the log??

Maybe something like the following is happening: 1. [No timeout is set to `net.Dialer`](https://github.com/cybozu-go/transocks/blob/2198aaeb4d1afabeaef63bd2ac521d6da2b47427/server.go#L48) 2. [Something bad happens at the proxy server and a lot of `proxy.Dialer.Dial` get blocked](https://github.com/cybozu-go/transocks/blob/2198aaeb4d1afabeaef63bd2ac521d6da2b47427/server.go#L108) 3....