Nishim Goyal

Results 12 comments of Nishim Goyal

Hey @Amxx ! I would like to assist in this build. Please let me know if you need any help or have any tasks for me!

Turns out the part tot he right of the ```=``` sign is ignored, and the variable gets initialised with the default value.

I would like to work on this change. Just for clarity, should this change the ```Address.fromString()``` method, or only in the ```ethereum.getBalance()``` function? In my opinion, I think we should...

@snreynolds I am ok with this implementation. Do let me know if and when this gets finalised.

Hey @snreynolds! Any update on the design?

The tests are passing locally. Some issue with the lib folder is causing tests to fail here...Help appreciated

It will cause problems in using ```vm.etch```. It does not deal well with address values in a range of [1-10](https://github.com/foundry-rs/foundry/issues/1159).

Sorry for the misunderstanding @Philogy ! I have opened a PR with what I think is the desired implementation. Do have a look.

On an initial attempt with making the ```PoolKey``` ```calldata``` instead of ```memory```, the gas only seems to be increasing. The `addLiquidity` snap goes up by 2000.

@snreynolds done!