Anubhav

@harikrongali - can this be converted to a bug, as selector field should be mandatory for rollouts. Without selector, a rollout is of no use.

@ramaraochavali: is memory leak mentioned in this issue applicable to 1.13 as well? I see from the issue description, that you did an upgrade to the master branch.

@ramaraochavali - but DRs do not have support for failure percentage? Reference: https://istio.io/latest/docs/reference/config/networking/destination-rule/#OutlierDetection It might be a good use case to support in DRs.

> > If we consider using consecutive5xxErrros, then a high TPS client might need the value to be: 100, but for a low TPS client, the value could be 10....

@ramaraochavali Is there an example you can provide for enabling this via Envoyfilter?

Thanks @ramaraochavali for the example: ```yaml apiVersion: networking.istio.io/v1alpha3 kind: EnvoyFilter metadata: name: outlier-on-percentage namespace: default spec: configPatches: - applyTo: CLUSTER patch: operation: MERGE value: outlier_detection: failure_percentage_threshold: 84 workloadSelector: labels: app:...

> Looks good. I am worried this this can happen for other events like DestinationRule etc when they are added to customer namespaces. Should we implement this in the controllers...

Ask is: In order to enable locality based load balancing without outlier detection what is the recommended approach?

Our assumption was that locality based lb should not depend on outlier detection, and just enabling the flag  should have been enough.

> The intent behind this is that without outlierDetection, we cannot detect failing workloads, so will never failover at all. IE its not "failover" just "only send to same zone"...