Nir Soffer

Code that need to run as root is using the supervdsmd daemon to run function from vdsm code as root. Some code have smart wrapper that run calls supevdsmd API...

Isolate tests running as root locally

1

Some tests like storage tests (lvm, blocksd) require root. It is possible to run them like this: sudo ~/.venv/vdsm/bin/tox -e storage tests/storage/lvm_test.py But after that, some files in .tox, tests...

- Rename automation to ci - Remove legacy ovirt ci files Issues: - check-patch.packages is used in README.md for development setup. Create a script for setting up development environment?

Fix code scanning alert - Insecure temporary file

1

Tracking issue for: - [ ] https://github.com/oVirt/vdsm/security/code-scanning/2

This module was added to handle differences between python versions: - simplejson on RHEL 6.x - subprocess32 on python 2 - missing glob.escape on python 2 - using inspect.getargspec on...

Tests too slow, need much faster feedback

5

Even after #13, tests are too slow. $ tox -e 2.7 -- py.test -v --durations=10 2.7 develop-inst-nodeps: /home/nsoffer/src/python-manhole 2.7 runtests: PYTHONHASHSEED='4080427460' 2.7 runtests: commands[0] | py.test -v --durations=10 ============================================================================= test...

manhole socket not removed when terminating a process

6

Although manhole register the removal function using atexit module, the removal function is not run when sending the process SIGTERM. To reproduce: 1. Create a script:: import manhole import time...

The Quickstart document says[1]: cluster-test.yaml: Cluster settings for a test environment such as minikube. But the cluster-test is using: spec: - dataDirHostPath: /var/lib/rook which does not work for minikube because...

Build is broken

1

Trying to build the sdk on Fedora 36 following the README: ``` $ mvn package -Dskipflake=true -DskipTests=true [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] Reactor Build Order: [INFO] [INFO] oVirt...

Fix profile list when profiles directory is missing

7

This was reported in [1] and fixed in [2] in 2019, but later it was broken by [3] in commit c3aafaeeb4541b0cd5303afe211fe281dbf5e4f3. `listProfiles()` can return `os.ErrNotExist` from `os.ReadDir()` so it must...