Nir Soffer

I don't think we need unit tests and specially not complicated mocking and stubs. This is very simple code with almost no logic, reusing ready components (like the interactive console)....

Adding manhole.uninstall() would be useful for application that want to ensure that the manhole is cleanup properly. manhole.uninstall() should 1. remove the socket from the file system. Connected client should...

Workaround: define a signal hanlder for SIGTERM: ``` import signal import sys def handle_sigterm(signo, frame): print "Terminated" sys.exit(128 + signo) signal.signal(signal.SIGTERM, handle_sigterm) ```

I guess it should, maybe under "Known issues".

I think we can register the signal handler in manhole, checking that no signal handler was installed before that: ``` if signal.getsignal(signal.SIGTERM) == signal.SIG_DFL: signal.signal(signal.SIGTERM, _handle_sigterm) ``` If a user...

I think this issue is resolved by #8, so we can close it now.

This is not something that should be configurable. We can avoid patching stdin, by taking input directly from the socket - but you cannot avoid patching stdout and stderr -...

I never tried it. I think that the safest way would be to use all sys.stdxxx files as you do now. I would close this issue for now.

I think it is incorrect - you want output from all threads to go to your console. For example, you may call a function that start a thread and run...

It will not work for multiple connections. It will allow each connection to run code like: print "foo" But again if you start another thread, no connection will get the...