nibabel icon indicating copy to clipboard operation
nibabel copied to clipboard

BUG: CSA reader

Open reddigari opened this issue 5 years ago • 0 comments

https://github.com/nipy/nibabel/blob/b46efa35fe6170168db6bd5b1f6607a07389e69c/nibabel/nicom/csareader.py#L121-L132

I think the definition of tag0_n_items might be a incorrect. The docs (that describe the SPM implementation) say to use the n_items of the first tag, which here corresponds to the condition tag_no == 0, not 1. (Feels like a slip while porting 1-indexed MATLAB code). This would make the value calculated on L132 wrong for every item in every tag.

There are no test files with a CSA1 header, and I don't have any, so I can't confirm this.

reddigari avatar Sep 23 '19 14:09 reddigari