nibabel icon indicating copy to clipboard operation
nibabel copied to clipboard

MNT: blue/isort/flake8 → ruff

Open DimitriPapadopoulos opened this issue 2 years ago • 5 comments

Fixes https://github.com/nipy/nibabel/pull/1288#discussion_r1436219280.

DimitriPapadopoulos avatar Dec 26 '23 13:12 DimitriPapadopoulos

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.25%. Comparing base (c445edd) to head (066431d).

Files Patch % Lines
nibabel/cmdline/diff.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   92.26%   92.25%   -0.02%     
==========================================
  Files          99       99              
  Lines       12472    12453      -19     
  Branches     2566     2555      -11     
==========================================
- Hits        11507    11488      -19     
  Misses        642      642              
  Partials      323      323              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 26 '23 13:12 codecov[bot]

Also need to update the tox environments:

Done.

@effigies It's now ready for reviewing.

DimitriPapadopoulos avatar Dec 26 '23 13:12 DimitriPapadopoulos

Bumping ruff from 0.1.9 to 0.3.0 is unexpectedly intrusive - lots of change by ruff format.

DimitriPapadopoulos avatar Mar 05 '24 16:03 DimitriPapadopoulos

Thanks again for doing this, @DimitriPapadopoulos! Made a bunch of small comments.

effigies avatar Mar 27 '24 14:03 effigies

I think I have addressed all the issues - plus some minor new changes.

DimitriPapadopoulos avatar Mar 27 '24 14:03 DimitriPapadopoulos

@DimitriPapadopoulos There are several unaddressed comments above. They're hidden by default.

effigies avatar Mar 29 '24 13:03 effigies

I think I have addressed all of them. Note that I rebased to fix a merge conflict.

DimitriPapadopoulos avatar Mar 29 '24 13:03 DimitriPapadopoulos

Or not :smile:

The quantity of changes pushes the GitHub web interface to its limits. I have a hard time navigating the comments.

Still one to address, almost there.

DimitriPapadopoulos avatar Mar 29 '24 13:03 DimitriPapadopoulos