Reading freesurfer stats files correctly
A couple thoughts:
-
Why a class with only static methods? I think flat functions would make more sense and be consistent with this module.
-
Is it possible to do what you want with plain numpy? Pandas is a very heavy dependency that we are unlikely to make an installation requirement.
The code has been revised regard to your comments
Codecov Report
Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
Project coverage is 95.33%. Comparing base (
276f786) to head (02334f4).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| nibabel/freesurfer/io.py | 35.71% | 9 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
- Coverage 95.36% 95.33% -0.03%
==========================================
Files 207 207
Lines 29680 29694 +14
Branches 4992 4996 +4
==========================================
+ Hits 28305 28310 +5
- Misses 935 944 +9
Partials 440 440
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@simkarwin Sorry about the long radio silence. Any interest in finishing this up?