android-templates icon indicating copy to clipboard operation
android-templates copied to clipboard

[#352] [Template] 2/2: Setup the nav graph and navigation logic

Open luongvo opened this issue 2 years ago • 1 comments

Resolves https://github.com/nimblehq/android-templates/issues/352

What happened 👀

Bring all necessary changes from Compose Sample project #367 to the Compose Template.

Insight 📝

  • There is no Second screen at the template level.

Proof Of Work 📹

All the logic should be the same as what we did in Compose Sample project ✅

luongvo avatar Dec 13 '22 04:12 luongvo

8 Warnings
:warning: Big PR
:warning: Uh oh! BaseViewModel.kt is under 95% coverage!
:warning: Uh oh! MainActivity.kt is under 95% coverage!
:warning: Uh oh! Your project is under 80% coverage!
:warning: Uh oh! AppDestination.kt is under 95% coverage!
:warning: Uh oh! AppNavigation.kt is under 95% coverage!
:warning: Uh oh! HomeScreen.kt is under 95% coverage!
:warning: Uh oh! Theme.kt is under 95% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 29.95%

Coverage of Modified Files:

File Coverage
BaseViewModel.kt 0.00%
MainActivity.kt 0.00%

Modified Files Not Found In Coverage Report:

AppDestination.kt AppNavigation.kt AppNavigation.kt Configurations.kt HomeComposeScreen.kt HomeComposeViewModel.kt HomeScreen.kt SecondScreen.kt Theme.kt Versions.kt build.gradle.kts build.gradle.kts

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 14.62%

Coverage of Modified Files:

File Coverage
AppDestination.kt 0.00%
AppNavigation.kt 0.00%
BaseViewModel.kt 0.00%
HomeScreen.kt 0.00%
MainActivity.kt 0.00%
Theme.kt 0.00%

Modified Files Not Found In Coverage Report:

Configurations.kt HomeComposeScreen.kt HomeComposeViewModel.kt SecondScreen.kt Versions.kt build.gradle.kts build.gradle.kts

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Dec 13 '22 09:12 github-actions[bot]

Code-wise LGTM. I just have one idea that was raised at https://github.com/nimblehq/android-templates/pull/367#discussion_r1053967218.

lydiasama avatar Dec 21 '22 04:12 lydiasama

@lydiasama Would you mind having the first Approval? ❤️

luongvo avatar Dec 27 '22 09:12 luongvo

@hoangnguyen92dn Any last remarks? ⭐

toby-thanathip avatar Dec 28 '22 10:12 toby-thanathip