android-templates
android-templates copied to clipboard
[#369] Update deprecated Detekt attrs in all templates
https://github.com/nimblehq/android-templates/issues/369
What happened 👀
There is some Detekt attrs
deprecated need to fix them.
Insight 📝
- Update
attr
->threshold
tofunctionThreshold
forLongParameterList
. - Update
attr
->ignoreOverriddenFunction
toignoreOverridden
forMemberNameEqualsClassName
. - Update
attr
->excludeAnnotatedProperties
toignoreAnnotated
forLateinitUsage
. - Update
attr
->excludeAnnotatedClasses
toignoreAnnotated
forUseDataClass
. - And for the left, we need to use
YAML array
instead ofcomma-separated
string by following this pattern[ '' ]
. - We have updated
functionPattern
forFunctionNaming
from^([a-z$][a-zA-Z$0-9]*)|(`.*`)$
to[a-zA-Z][a-zA-Z0-9]
to make it shorter.
Proof Of Work 📹
1 Warning | |
---|---|
:warning: | Uh oh! Your project is under 80% coverage! |
Kover report for template-xml:
🧛 Template - XML Unit Tests Code Coverage: 29.95%
Coverage of Modified Files:
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
detekt-config.yml detekt-config.yml detekt-config.yml detekt-config.yml
Codebase cunningly covered by count Shroud 🧛
Kover report for template-compose:
🧛 Template - Compose Unit Tests Code Coverage: 13.05%
Coverage of Modified Files:
File | Coverage |
---|
Modified Files Not Found In Coverage Report:
detekt-config.yml detekt-config.yml detekt-config.yml detekt-config.yml
Codebase cunningly covered by count Shroud 🧛
Generated by :no_entry_sign: Danger
@Wadeewee FYI, All your insight description should be at the What happened
topic. 🙏🏻 The Insight
section is about why did you decide to do this way, how can you test it, or is there any issue about other way. Please consider in the next time. 🙏🏻