android-templates icon indicating copy to clipboard operation
android-templates copied to clipboard

[#369] Update deprecated Detekt attrs in all templates

Open Wadeewee opened this issue 2 years ago • 1 comments

https://github.com/nimblehq/android-templates/issues/369

What happened 👀

Screen Shot 2565-12-12 at 15 17 38

There is some Detekt attrs deprecated need to fix them.

Insight 📝

  • Update attr -> threshold to functionThreshold for LongParameterList.
  • Update attr -> ignoreOverriddenFunction to ignoreOverridden for MemberNameEqualsClassName.
  • Update attr -> excludeAnnotatedProperties to ignoreAnnotated for LateinitUsage.
  • Update attr -> excludeAnnotatedClasses to ignoreAnnotated for UseDataClass.
  • And for the left, we need to use YAML array instead of comma-separated string by following this pattern [ '' ].
  • We have updated functionPattern for FunctionNaming from ^([a-z$][a-zA-Z$0-9]*)|(`.*`)$ to [a-zA-Z][a-zA-Z0-9] to make it shorter.

Proof Of Work 📹

Screen Shot 2565-12-13 at 10 50 38

Screen Shot 2565-12-13 at 10 51 42

Screen Shot 2565-12-13 at 10 52 35

Screen Shot 2565-12-13 at 10 55 00

Wadeewee avatar Dec 13 '22 04:12 Wadeewee

1 Warning
:warning: Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 29.95%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

detekt-config.yml detekt-config.yml detekt-config.yml detekt-config.yml

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 13.05%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

detekt-config.yml detekt-config.yml detekt-config.yml detekt-config.yml

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Dec 13 '22 04:12 github-actions[bot]

@Wadeewee FYI, All your insight description should be at the What happened topic. 🙏🏻 The Insight section is about why did you decide to do this way, how can you test it, or is there any issue about other way. Please consider in the next time. 🙏🏻

lydiasama avatar Dec 15 '22 03:12 lydiasama