android-templates icon indicating copy to clipboard operation
android-templates copied to clipboard

Fix: Files and folders are not cleaned after setup

Open suho opened this issue 2 years ago • 5 comments

Issue

After running the setup scripts, files and folders are not cleaned. As a result, I don't know which folder uses for the project.

For example, I run kscript new_project.kts package-name=co.nimblehq.suvkmmsurveys.android app-name=Surveys. Surveys or template is the right folder? 🤔

Screen Shot 2022-08-23 at 10 32 57

Expected

The scripts should clean all files and folders that are not needed for the project.

Steps to reproduce

  1. Run the setup script
  2. Check the folder after the project is generated

suho avatar Aug 23 '22 03:08 suho

I think we could rather turn this into a feature flag, because maybe you will want to continue using this template for another project without checking out the repo again right? Perhaps an option to the original command -d == delete the template after finished could be done, but not a bug

sleepylee avatar Aug 23 '22 03:08 sleepylee

or also, a path to specify where to place the templated project dir 💭

sleepylee avatar Aug 23 '22 03:08 sleepylee

@suho I'm gonna agree with @sleepylee, this sounds like a feature rather than a bug. How about we open a new discussion and let the team vote there? 😄

ryan-conway avatar Aug 23 '22 04:08 ryan-conway

@ryan-conway you can make the call 🙆‍♂️ just make sure that the answer pleased @suho first

sleepylee avatar Aug 23 '22 04:08 sleepylee

@sleepylee @ryan-conway All good from my side :D. Please help me to change the label. I can't change it :D

suho avatar Aug 23 '22 04:08 suho

Resolved by #436

ryan-conway avatar Jul 06 '23 04:07 ryan-conway