Nima Zareian
Nima Zareian
Good work on finding this bug! With regards to this > Also, the stadium obstacle is not fully effective at keeping out the goalie and crease defenders, in the edge...
@sauravbanna We should discuss this change one of these weekends and see if it fits in with our updated architecture...
A few of my comments from when I reviewed this PR before and forgot to submit my comments. Feel free to ignore them if they're not applicable anymore.
Currently, the way the `ProtoConfigurationWidget` widget works (aka the parameter tree widget in Thunderscope) is that everytime a value is modified by the user, this [callback](https://github.com/UBC-Thunderbots/Software/blob/2d95d775e342a60241b4d1e9fc5a0671d7ce369a/src/software/thunderscope/widget_setup_functions.py#L214-L217) is called which sends...
@sauravbanna Do you want to continue this PR? If not, we should close it and open a ticket for someone else to pick it back up from what you've written.
@sauravbanna Could you pull from master so CI can run and the failing tests could hopefully pass?
I think we should merge the tests you've added, but we probably don't need the ShootOrPassPlay changes since we've made various changes and fixes to this play on our WIP...
> I think we should merge the tests you've added, but we probably don't need the ShootOrPassPlay changes since we've made various changes and fixes to this play on our...
Related to #2514
#2945 includes detail on the updated relationship we use for variable kick power.