Nils Eling

Results 31 comments of Nils Eling

Hi @kevinrue I'm currently on holidays but will post my review as soon as I'm back (10th September).

Have you bumped the package version? In the linked Github repo I don't see new changes and the version is still at `0.99.1`.

Sounds good, that's also what I wanted to suggest as I don't have major comments anyway. First of all, thanks for submitting `iSEEhub`. The package is in a great shape...

Did you `git push upstream main:master`?

I have now accepted the package for inclusion in Bioconductor allowing the `BiocManager::install()` call as an exception.

Hi all, not sure if my comment is relevant here but I was in a similar situation when writing [imcRtools](https://bioconductor.org/packages/release/bioc/html/imcRtools.html). I decided to not support handling of multiplexed images as...

Hi @arcolombo That's a good point and we often observe that the nuclear mask potentially with a bit of pixel expansion leads to sufficient signal for phenotyping. You can test...

I wouldn't worry too much about this as T cells are quite small and mainly consist of the nucleus anyway.

`testthat` snapshots have now been added. Still need to wait until [this](https://github.com/rstudio/shinytest/issues/243) is resolved to fully test the whole app.