Qi Ni

Results 136 comments of Qi Ni

/remove-lifecycle stale

We can add an annotation here https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/pkg/consts/consts.go I recommend `service.beta.kubernetes.io/azure-load-balancer-ip`, what do you think?

Hi @kanha-gupta, do you still plan to do this one?

https://github.com/kubernetes-sigs/cloud-provider-azure/pull/2428 to introduce a new annotation. Use this issue to track as we need to completely remove the service.Spec.LoadBalancerIP in the future.

A possible solution is to check the existence of the resource group before returning the 404 error. In this way, the resource group client should be added to the repo.

ref: https://github.com/kubernetes/kubernetes/pull/93962

looks it is not easy to test, @andyzhangx any ideas?