cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Introduce a new service annotation to replace service.Spec.LoadBalancerIP

Open nilo19 opened this issue 2 years ago • 8 comments

What would you like to be added:

According to https://github.com/kubernetes/api/blob/master/core/v1/types.go#L4434, we need to introduce a new annotation to replace the loadBalancerIP, as it will be removed in the future.

Why is this needed:

https://github.com/kubernetes-sigs/cloud-provider-azure/issues/1781#tasklist-block-ecb5dc84-8396-45ad-9fd6-b5ed9cd8a154

nilo19 avatar May 27 '22 03:05 nilo19

/assign

kanha-gupta avatar May 27 '22 19:05 kanha-gupta

what do we have to replace it with ?

kanha-gupta avatar May 27 '22 19:05 kanha-gupta

We can add an annotation here https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/pkg/consts/consts.go I recommend service.beta.kubernetes.io/azure-load-balancer-ip, what do you think?

nilo19 avatar May 28 '22 02:05 nilo19

I think you are right

kanha-gupta avatar May 28 '22 11:05 kanha-gupta

Hi @kanha-gupta, do you still plan to do this one?

nilo19 avatar Jun 08 '22 01:06 nilo19

/assign

AfrouzMashayekhi avatar Jun 21 '22 08:06 AfrouzMashayekhi

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 19 '22 09:09 k8s-triage-robot

https://github.com/kubernetes-sigs/cloud-provider-azure/pull/2428 to introduce a new annotation. Use this issue to track as we need to completely remove the service.Spec.LoadBalancerIP in the future.

nilo19 avatar Oct 05 '22 12:10 nilo19

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 04 '22 12:11 k8s-triage-robot

this was added by https://github.com/kubernetes-sigs/cloud-provider-azure/pull/2428.

feiskyer avatar Nov 07 '22 03:11 feiskyer