Edward Anderson

Results 111 comments of Edward Anderson

Applied all my feedback in the async branch. I want to rewrite the test suite (~800 LoC) to accomplish a few goals. 1. Use Mocha instead of Jasmine to take...

@honi Thanks, I'll take a look at it. Still though, I'm unclear on what problems you ran into with your original implementation that deserved a rewrite. I can understand wanting...

I believe async is correct and complete. I have reviewed the code thoroughly and found nothing wrong. I am currently finishing up a complete rewrite of the tests, which are...

Status update: - I have converted the test suite from Jasmine to Mocha, which has cleaner support for testing async libraries. - At the same time, all tests have been...

@elad For now I would like to review everything coming into master, so I will make it a priority to do so, at longest within a couple days.

@SonoIo I haven't reviewed your [BackboneIDBDualStorage](https://github.com/insideabit/Backbone.IDBDualStorage) fork yet and will not likely have time to before February like I mentioned in the other thread. Based on what you've seen though,...

@SonoIo (Numbers edited into your previous comment) 1. In a similar way to how we allow swappable [database adapters](https://github.com/nilbus/Backbone.dualStorage/blob/async/backbone.dualstorage.adapters.coffee), we can also allow a swappable [Store](https://github.com/nilbus/Backbone.dualStorage/blob/async/backbone.dualstorage.coffee#L69) class, which is what...

@SonoIo It sounds like your ideas are compatible with this project. Feel free to work on merging if you have the time and desire.

I welcome patches that improve the efficiency! If you're up to it, feel free to ask me any questions you have along the way. Be aware of the `async` branch,...

Yes, this is a known issue. #53 was open to address this, but I'll keep this open instead as you have described the problem rather nicely. I am tied up...