Edward Anderson

Results 111 comments of Edward Anderson

`store.clean` is the call you're looking for. It wasn't obvious, because it can clean both dirty and destroyed records and doesn't contain either string. Here's what generally happens (I'll go...

I didn't mean to suggest that we add any new methods on the collection. Instead I was just thinking that it might be nice if the existing methods didn't reference...

Sorry for miscommunicating. I am not against adding new methods as they are needed. I was under the impression that you added some of those because I had suggested adding...

I really like where you're going with this. Are you doing the try/catch to catch the case when `resp` doesn't have `done`, or are you trying to catch an error...

Yes. Later down the road if we call a property or method that doesn't exist in getResp, it'll also catch those. For example: - `collection` isn't the collection we expected...

Looking at this at a higher level, I do understand the need to do this: ``` coffeescript photos.fetch().done -> ... ``` What I don't understand is how this change helps...

Okay, I think I understand the purpose of this then. The issue was that the `resp` passed to `parseBeforeLocalSave` was not a deferred object, right?

I like the direction you're going with this. Sorry I couldn't get to reviewing it until now. I want to give some thought to the names localSyncFirst and remoteSyncFirst. Maybe...

This will need to have unit tests before we can pull it in.

I haven't looked at the localSyncFirst implementation in great detail yet. However I won't be able to accept this as-is because of the massive code duplication between `localSyncFirst` and `remoteSyncFirst`....