Nicolas PHILIPPE comments

Results 321 comments of


                                            Nicolas PHILIPPE

Implement Symfony\Contracts\Service\ResetInterface in the TestTransport

closed in favor of #90

[Framework bundle] Cleanup error and exception handlers on Kernel shutdown

@derrabus what if `KernelTestCase::ensureKernelShutdown()` would restore PHPUnit exception handler as well? It would at least prevent the problem to occur for user, which uses `KernelTestCase`, but still, the problem raised...

[Framework bundle] Cleanup error and exception handlers on Kernel shutdown

> That's weird. It's the error handler that deals with deprecations, not the exception handler. I know, but as soon as you boot the kernel in a "before class" hook...

[Framework bundle] Cleanup error and exception handlers on Kernel shutdown

I don't know if both problems are related. If Symfony's error handler is registered too soon, it would mute PHPUnit's error handler :shrug:

Invalid service "App\Foundry\PostFactory": class "Zenstruck\Foundry\ModelFactory" not found while loading "App\Foundry\PostFactory"

Hey @norkunas, does this problem still occur with Foundry v2 / last Symfony version?

[1.x] fix using stories with simple objects

based on @kbond's comment I'm closing this, this works in 2.x see https://github.com/zenstruck/foundry/pull/589

doc: update

something else: WDYT about documenting [this little, but still useful, behavior](https://github.com/zenstruck/foundry/blob/2.x/tests/Integration/Persistence/GenericFactoryTestCase.php#L172) (the stuff with `__index`)?

[2.x] remove `@method` from `make:factory`

Hi! Which method are you talking about?

[2.x] [rector] error thrown using `FoundrySetList` && `PersistenceResolver` w/ custom generator

thank you to give a try to this whole upgrade path! I've tested it on several projects of mine, as well as @kbond did, but that's cool it gets tested...

[2.x] [rector] error thrown using `FoundrySetList` && `PersistenceResolver` w/ custom generator

Hi @jrushlow could you show your `rector-bootstrap.php` file please? it seems strange that you have the problem, because it seems you're passing the entity manager from Symfony's container, and based...