foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Published 20 hours ago • verified publisher icon zenstruck

[1.x] fix using stories with simple objects

Open jrushlow opened this issue 1 year ago • 2 comments
trafficstars

  • fix using stories with objects that can't be persisted

Current behavior: image

This is intended to be legacy code that shouldn't be merged / released in 2.x.

fixes: #573

jrushlow avatar Mar 30 '24 15:03 jrushlow

On one hand, I definitely think this feature should land in Foundry, but on another hand, I'm a little bit reluctant to add new features to foundry 1.x.

I'd make the argument that this is a bug fix rather than a new feature. Having said that, I completely understand the thought process behind merging this into 1.x vs merging this / doing something else in 2.x. I'm good with it either way.

jrushlow avatar Apr 03 '24 11:04 jrushlow

Hey, sorry for the delay reviewing. I'm inclined to add this to 2.x only. We are really close to a release and it's getting to be a real burden to port stuff from 1.x to 2.x.

kbond avatar Apr 20 '24 14:04 kbond

based on @kbond's comment I'm closing this, this works in 2.x see https://github.com/zenstruck/foundry/pull/589

nikophil avatar Jun 03 '24 08:06 nikophil