Niko Matsakis comments

Results 606 comments of


                                            Niko Matsakis

`or_fun_call` isn't always a performance lint

I ran into this same issue! It's not just `Vec::new`, I think the same would be true of `HashMap::new` and other standard library collections.

significant_drop_in_scrutinee is confusing and not very useful for for loops

I believe the key thing to look for is match guards that are *temporaries*. For example, it is surprising to many people that `some_ref_cell` remains "locked" in this example... ```rust...

Make contributing.md into a series of tutorials

It's true, I've been advocating for documentation of procedures and things to move to forge, with rustc-dev-guide more focused on "how the code works", but I think that having some...

"The parser"

@Michael-F-Bryan you can certainly bounce questions off of me; I would say the main *owner* of the parser is @petrochenkov

"The parser"

Copying some stuff I wrote in #21 that seems relevant: > What things would someone need to know when either working on the parser or trying to use the parser...

"The parser"

@Michael-F-Bryan > I'm surprised how familiar a lot of this is! Yeah, it's your basic recursive descent parser. Nothing too fancy. =) > I'm interested to find out how libsyntax...

Writing mentored issues

That's a great idea yes

Writing mentored issues

I could try to write something here maybe. I have a few thoughts.

Writing mentored issues

Key points would be: * You don't have to spell out every detail -- in fact, maybe it's better if you don't * The main thing people need is (a)...

Expose more than one rule?

I don't think Lane Table helps in particular but I've not given it a lot of thought. I think LALRPOP permits you to tag multiple rules as `pub` but IIRC...