rustc-dev-guide icon indicating copy to clipboard operation
rustc-dev-guide copied to clipboard

Writing mentored issues

Open davidtwco opened this issue 7 years ago • 7 comments

Not sure if this is the right fit for this book, it relates more to the process of contributing rather than the technical details. Would it be useful to have a section in the guide for writing mentored issues?

The intention being that experienced contributors who are just getting started writing mentored issues would be able to review it and structure their mentoring instructions in as helpful and useful a way as possible and that the quality of the instruction would then be consistent?

It would contain things that mentors have found beneficial to include in mentoring instuctions; or things those that have done some mentored issues found useful or not so useful; examples of good and bad instruction?

Edit: only just now noticed that mentoring is mentioned in #25 so this might be a dupe.

davidtwco avatar Feb 23 '18 20:02 davidtwco

:+1: I think it's a great idea. We can leave it open.

mark-i-m avatar Feb 23 '18 21:02 mark-i-m

That's a great idea yes

nikomatsakis avatar Feb 24 '18 01:02 nikomatsakis

@nikomatsakis Would you be able to write this or suggest someone else to write it? Unfortunately, by construction this chapter requires people who are in high demand.

mark-i-m avatar Jan 24 '19 04:01 mark-i-m

Triaged: @davidtwco we were wondering if you had any thoughts you would like to write up? Otherwise, our current direction seems to be moving procedures to the forge....

mark-i-m avatar May 19 '20 20:05 mark-i-m

@mark-i-m I can’t think of anything that I’d write up at the moment - I submitted this issue so long ago that whatever details I was thinking of at the time have subsequently vanished.

I think the forge would be a good fit for this given what you’ve said.

davidtwco avatar May 19 '20 23:05 davidtwco

I could try to write something here maybe. I have a few thoughts.

nikomatsakis avatar Jun 10 '20 10:06 nikomatsakis

Key points would be:

  • You don't have to spell out every detail -- in fact, maybe it's better if you don't
  • The main thing people need is (a) the high-level intent, (b) some pointers into the code so they know where to get started, and (ideally) (c) some links into the rustc-dev-guide
  • And of course follow-up with questions. It's a good idea to make explicit the best way for people to contact you. Privmsg is often easiest but whenever possible it's good to move the conversation public or at least leave summaries, lest the person winds up not finishing, so that you have a record.
  • Linking to the rustc rustdoc I (personally) think is also good, in part so that people learn it exists :)

nikomatsakis avatar Jun 10 '20 10:06 nikomatsakis