Niko Matsakis comments

Results 606 comments of


                                            Niko Matsakis

Propagate deref coercion into block

Sorry @ldm0 ! I'll try to give useful feedback ASAP

Propagate deref coercion into block

I'm reviewing this now.

Propagate deref coercion into block

Apologies for the very long delay.

Propagate deref coercion into block

Sorry @ldm0, got underwater again, but coming out of it :)

Propagate deref coercion into block

Thanks. I'll take a look at the tests over the next few days! I'm trying to allocate some time every day for reviewing and notifications...

Inherent static methods on traits do not play well with associated types

@aturon huh, that's annoying!

Inherent static methods on traits do not play well with associated types

@eddyb > Should we infer unspecified associated types in expressions, just like type parameters? Hmm, probably, yes. However, that alone wouldn't be good enough. We'd also need the "GC" strategy...

Inherent static methods on traits do not play well with associated types

@eddyb I was just going on the example, where `T` was not needed; but yeah perhaps in real cases, `T` would be used.

Invoking a type object with no parameters should always yield an instance of that type

The one form that is not applicable across _all_ type objects is `T(buffer, offset)`, though one can write `T.Array(buffer, offset, 1)` (or whatever) to create an array of length one.

Overlap rules

The branch 2022-08-coherence includes some preliminary work here: It introduces an overlap check and checks that the various impls that are in scope do not have types that successfully unify....