Nikolay Kuznetsov

I agree with @gianarb, repo per canned container sounds like an overkill. If submodules approach work then this is probably a way to go.

> To many dependencies to download with the library @gianarb, good point. I think we should try to minimize dependencies a new canned container introduces. In order to start a...

Btw, testcontainers-go already depends on Redis and MySQL clients :(

@rnorth thanks for your input about! What is your opinion about the default version of canned containers/modules? Java version comes with a Postgres module which has version 9.6.12 under the...

@ClaytonNorthey92 I have checked your suggested interface. By the way, we have two types of entities in this lib: request and container. So we should set a version to request...

Well, looks like pulling of an image happens before logging that container is being started. Need to be fixed.

So it is still not supported?

I also have this issue on Mac in tests. Postgres is running using testcontainers. github.com/jackc/puddle/v2 v2.2.2 ``` runtime.gopark(proc.go:425) runtime.goparkunlock(proc.go:430) runtime.semacquire1(sema.go:178) sync.runtime_Semacquire(sema.go:71) sync.(*WaitGroup).Wait(waitgroup.go:118) github.com/jackc/puddle/v2.(*Pool[go.shape.*uint8]).Close.deferwrap1(pool.go:180) runtime.deferreturn(panic.go:605) github.com/jackc/puddle/v2.(*Pool[go.shape.*uint8]).Close(pool.go:195) github.com/jackc/pgx/v5/pgxpool.(*Pool).Close.func1(pool.go:387) sync.(*Once).doSlow(once.go:76) sync.(*Once).Do(once.go:67) github.com/jackc/pgx/v5/pgxpool.(*Pool).Close(pool.go:385) ```...

I am using golang-migrate library and this code to make it work with pgx5. I suspect it might leak connection here.. ```go func (r repo) ApplyMigrations() error { db :=...

So yes, for me this snippet was the root cause. ```go db := stdlib.OpenDBFromPool(r.pool) defer db.Close() ``` Now I don't take a connection from pgx5 pool, but use a standard...