Nikolas Zimmermann

Results 24 comments of Nikolas Zimmermann

I would like to hear opinion from our code sheriffs - @darinadler would be a great candidate to comment on this.

There were a few issues with non-LBSE, legacy builds. Should be fixed now.

Checked and fixed the EWS issues, all the same root cause s/isSVGHidden/isLegacySVGHidden/ is missing in a few places -- got lost during the splitting of the commits.

Rebased & squashed + fixed GTK build issue (missing RenderLayer.h) include. Let's wait for another EWS round before landing.

@smfr - ping :-) let's get this old PR out of my way ;)

Addressed the comments from @smfr, rebased and squashed.

Great that you're back on this topic @shallawa - can you update us what changed? I just had a quick glance, and think you only rebased it, right? A few...

I adressed all comments, ready to go :-)

Will land it today, if Simon sees any issues, we can adress them in a follow-up.