WebKit
WebKit copied to clipboard
[LBSE] Fix MotionMark repaint issues
81a8745176acae0de74caa2622d66e61c6f6b320
[LBSE] Fix MotionMark repaint issues https://bugs.webkit.org/show_bug.cgi?id=270103 Reviewed by NOBODY (OOPS!). In LBSE transform changes do not result in relayouts, instead repaints are triggered. That failed to repaint the old position of an object before the transform change, only the new position - fix that. Covered by existing tests, when LBSE is active. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-and-object-creation-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-creation-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-pattern-and-object-creation-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/marker-orient-auto-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/non-scaling-stroke-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-deep-referencing-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-incorrect-tiling-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Copied from LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-and-object-creation-expected.png. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaled-pattern-space-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaling-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-skew-transformed-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-with-transformation-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/shapes-supporting-markers-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/foreign-object-repainting-after-modifying-container-transform-repaint-rects-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/foreign-object-repainting-after-modifying-transform-repaint-rects-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/image-repainting-after-modifying-container-transform-repaint-rects-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/image-repainting-after-modifying-transform-repaint-rects-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/shape-repainting-after-modifying-container-transform-repaint-rects-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/shape-repainting-after-modifying-transform-repaint-rects-expected.txt: * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::CSSSVGResourceElementClient::resourceChanged): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::repaintRendererOrClientsOfReferencedSVGResources const): (WebCore::RenderElement::repaintOldAndNewPositionsForSVGRenderer const): * Source/WebCore/rendering/RenderElement.h:
https://github.com/WebKit/WebKit/commit/81a8745176acae0de74caa2622d66e61c6f6b320
EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/81a8745176acae0de74caa2622d66e61c6f6b320)
Will land it today, if Simon sees any issues, we can adress them in a follow-up.
Commit message contains (OOPS!) and no reviewer found, blocking PR #25118
Oops, sorry @Ahmad-S792 didn't see that you already fixed the mq.
Oops, sorry @Ahmad-S792 didn't see that you already fixed the mq.
Happy to help. ๐
Committed 275702@main (a78e4b31c440): https://commits.webkit.org/275702@main
Reviewed commits have been landed. Closing PR #25118 and removing active labels.