Nikola Poša

Results 13 comments of Nikola Poša

What would be the benefit, use case for `getRateLimitStatus()`? I try to think of a rate limiter as a simple guard that either passes or fails, whereas detailed information contained...

Thank you very much @BrianHenryIE 👍🏻 > Adding $current to Status seems sensible. It looks like it could be done as a non-breaking change too. @jeremiegrenier Would something like this...

I think something is wrong with that inline `CacheInterface` implementation in the test itself. I don't have time to dig deeper, but try debugging inside `it_silently_returns_correct_status_when_limit_is_exceeded()` test.

Thanks! There is a custom rate limit strategy, take a look at: https://github.com/nikolaposa/rate-limit/blob/master/src/Rate.php#L46. I might document that in README.

I would be surprised if `Redis` extension does not take care of that on its own under the hood. I would expect that `incr()` always behave as it should regardless...

Ok, that confirms it. Can you create a PR that changes README with a suggestsion that serialization should be disabled?

... or perhaps we should enforce it here: https://github.com/nikolaposa/rate-limit/blob/master/src/RedisRateLimiter.php#L29, via `setOption()`.

Yeah, I thought about that afterwards, too, but perhaps something like checking whether flag is on + throw meaningful exception would is the most appropriate approach in my opinion.

What do you think would be the most sensible solution to this?

Hi, which version are you using? Also, put `require_once("./vendor/autoload.php");` at the top of your script, before `use` statements. Also, make sure that `vendor/autoload.php` really exists on that path, i.e. make...