Nikki Massaro
Nikki Massaro
Instead of `a11y-tree.testing.ts` being separated into its own file, a11y tree testing should be a part of all of the other test files.
> wdyt about calling this rh-video-player to match rh-audio-player? @bennypowers `rh-audio-player` uses HTML5 `audio`, has player controls, and captions/transcript. `rh-video` is a thubmail image over an `iframe`, with none of...
@marionnegp I stubbed out some of the docs. Feel free to pull this branch and add to what I started.
Questions for discussion at Monday's office hours: - Should the component open the cookies dialog out of the box, or is this a pattern that consumers have to implement? -...
> * Should the component open the cookies dialog out of the box, or is this a pattern that consumers have to implement? Nikki will reach out to ask more...
For the opt-in part: - slots for `consent-message` and `consent-button-text` - properties `require-consent` and `has-consent` - `consent-click` event to open cookie dialog
.@marionnegp and I met and tested colors with PrismJS's types. Here's what we found works best. ## Light Theme | Variable | Color | |-------- | ----- | | --rh-code-block-default-color...
> If a keyboard user is able to open the menu, then a mouse click should do the same. BOTH shouldn't be able to select a sub item. @hellogreg @zeroedin...
@bennypowers ptal