Nikita Popov

Results 517 comments of Nikita Popov

The assertion error is fixed by https://github.com/ircmaxell/php-cfg/commit/d43ed9f52f320cabf025a82b622bae9ecc48e483. However the way we handle bound closure variables currently is not good (and for the reference case outright violates SSA). Closure body also...

Follow-up fix: https://github.com/ircmaxell/php-cfg/commit/8e85ad3fb7b79b345cb49cceeb6bd982d83ea421 I didn't have notices enabled locally, so missed that part.

In https://github.com/ircmaxell/php-cfg/commit/0d54187759ac945e4cf02d8c8dff82fb121192e0 I've introduced a Func structure, so each function has a clearly separated CFG. The Funcs are collected in a Script, which is what is returned by the parser...

GraphViz printer fixed in https://github.com/ircmaxell/php-cfg/commit/1b0e384103c5484ee1778514fe89888c908309c5. Also added a printScript method to print all functions into one graph.

Not looked at this thoroughly yet, just some first thoughts: - This is causing test failures due to extra trailing blocks. Would be nice to get rid of those :)...

Regarding 4), linking every Op to the exception handler as an explicit branch target seems like overkill, but we could add it the to the containing block. I.e. either introduce...

The comments are stored as attributes on the node. There are some APIs for manipulating them: https://github.com/nikic/PHP-Parser/blob/46be4560c4cd4bab2b74882c0da39a4548a5cfbe/lib/PhpParser/Node.php#L90-L113 There is no direct API to drop comments, but you can use `$node->setAttribute('comments',...

> Is LNumber / DNumber deprecated in php-parser? As the comment above that line says, yes :) I don't think there is anything I can do about this, if `-a`...

This now works at least in one direction: We are able to generate the agents, import them into Flame and invoke the Flame with the generated starting state. The reverse...