Nikolay Donets comments

Results 8 comments of


                                            Nikolay Donets

updated multiscale_entropy to allow changing the sample_length that i…

Hey, thank you for the PR. Please refer to the issue #1 . The same topic was discussed there. In summary, there is a difference in calculation of sample entropy...

updated multiscale_entropy to allow changing the sample_length that i…

You are right about the last value. But my point was about the output type returned, in one case its an array, in another its a single value. I think...

issue about small test set

There might be differences in calculation between wiki and implementation here. I've provided implementation details in comments together with references. Please check them

issue about the example

This error is related to division by 0. Most probably it is because of the input: at some scale this operation appears and that's why there are nans/inf in the...

issue about small test set

Seems to be fixed with #28 ```python ts = [0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8] se1 = ent.sample_entropy(ts, 3, 0.2) # situation1: m+1=3, tolerance=0.2 se2 = ent.sample_entropy(ts, 3,...

Expose the train/split ratio in the model config

I believe this one is resolved with #648?

Geolocation feature extractor

Out of curiosity, according to GDPR, is it personal data? Should be optional maybe?

Sample Entropy not same value

I believe the differences in Sample Entropy values are due to variations in how each library implements the algorithm. You might want to check if the parameters you're passing are...