Nik Revenco

Results 190 comments of Nik Revenco

> Sweet, thanks for the PR 🙌 I also added a note to the readme on the new env variable

> Imo the other way around would make more sense since workspace is a bigger scope than document Ok, so I was previously of the opinion that the one with...

> `gO` should show current document symbols, that was always the plan for `gO`. Ok, that makes sense actually. I have changed it so that `grs` is workspace symbols, `gO`...

> workspace symbol search has overlap with `:tjump`. Given that you typically use it with a query I'm not sure if a dedicated keymap is warranted? I still feel like...

Ok, so I can see where you are coming from. I've removed grs

> Any issues with the comments above? Okay I have added your suggestions

> I'm hesitant on this one. > > I believe the intention of the exercise is to get learners to get more practice with using loops. The hint quite firmly...

> Yes, I repeat that the bar for adding new types of textobjects is quite high. You need to make a _much_ better case for a new one, including >...

> Without prejudicating any decision on whether this should be added: the name _must_ follow the corresponding highlight capture. Ok, so here's some information then In C its `type: (_)`...

Alternative suggestion: `@type` that will capture just any *type*, not necesserily a type_annotation or equivalents in other languages