Michal Čihař

Results 788 comments of Michal Čihař

"Terminology" was AFAIK used by Pootle, that's why some users got used to that. Not sure if either of your proposals is better, though...

The final solution should look like: * ~Prefer public address from GitHub~, done in 90e101139ac8c89c7c931e0d7eb3edf1560c701a * ~Fetch all verified addresses from GitHub and store them as `VerifiedEmail`~, done in b0cbaa31e0b7b05b8e554e1e839071bfef945a7d...

There are many questions related to this: * Should Weblate allow entering any address as committer e-mail without any verification? * Keeping the address private on Weblate side will avoid...

That commit just makes Weblate prefer the public e-mail address if you have it configured on GitHub.

When editing profile: ![obrazek](https://user-images.githubusercontent.com/212189/186112588-e855b82a-fc3f-4002-adf1-d0ed331bd5d1.png)

Weblate picks up public or primary mail. You can add and verify any e-mail and use that. Also, I've improved the GitHub integration in b0cbaa31e0 to fetch all verified e-mails,...

No, Weblate needs a working e-mail and doesn't allow different e-mail for commit and notifications. That's why this issue is still open. The desired solution has been outlined in https://github.com/WeblateOrg/weblate/issues/6508#issuecomment-1150862268,...

In more detail, what is missing: * The [VerifiedEmail](https://github.com/WeblateOrg/weblate/blob/072befc09cb5d66cb794343e940e50d6c9636a23/weblate/accounts/models.py#L347-L362) model needs to track information whether e-mail is suitable for e-mail delivery * Extend [get_all_user_emails](https://github.com/WeblateOrg/weblate/blob/072befc09cb5d66cb794343e940e50d6c9636a23/weblate/accounts/utils.py#L90-L99) to support filtering based on that,...

> I think that's the interesting part. Would we want to add a generic [[email protected]](mailto:[email protected]) E-Mail here for people not using GitHub but wanting privacy, or would we just disable...

VerifiedEmail is a database model. It's a database query using Django ORM. It fetches "email" field from the matching object and creates a set from that. The data needs to...