Nils Goroll

Results 592 comments of Nils Goroll

> I'm not arguing against VCL support for this I would think VCL should always be in control. But that's an implementation question, this conversation is regarding a CLI specification...

> > * you say you do not like options combined with arguments, so where are the `proto_options`? > > You are referring to this, right? > > > *...

So here's a concrete proposal: ``` socket.open [name] socket.close [-g grace] [name] socket.list socket.add [-c] [-p proto [-o proto_option ...]] [-a acceptor [-o acceptor_option ...]] name endpoint [endpoint_options...] socket.mod [-p...

@bsdphk @Dridi and myself are happy with the previous note now, we clarified some final points on IRC.

I think the current revision of https://github.com/varnishcache/varnish-cache/wiki/VIP33%3A-Socket.%2A-CLI-commands could use polish of the socket.list output. It was important to @Dridi to get away from the comma separated options, so I think...

Note from VDD: socket.add would probably take -t argument instead of -a and -p

What I think is happening here: For the first client run, `do_esi` is `true` only for the request to `/abort` and, [consequently](https://github.com/varnishcache/varnish-cache/blob/master/bin/varnishd/cache/cache_fetch.c#L542-L543), `do_stream` is `false` also only for the the...

Without having tried it, I think this is originally caused by this change from 26097fb091496f79ef9a38b22e3639735fb39280 ```diff req->doclose = SC_REM_CLOSE; req->acct.resp_bodybytes += VDP_Close(req->vdc); + + if (i && ecx->abrt) { +...

@slimhazard what about something like this ```perl sub vcl_miss { if (req.esi_level > 0) { set req.http.no-stream = "1"; } else { unset req.http.no-stream; } } sub vcl_backend_response { if...

During bugwash, @Dridi and myself had a discussion which was partly confusing to me. This comment is an attempt to clarify. Please correct me if you think that I am...