Nils Goroll
Nils Goroll
during bugwash, @bsdphk brought up the question if this could affect vsl clients, and while it does not look like it, `git grep` suggests that we should change some other...
My take: Integrate Dridis suggestion and update the docs, then it's a good improvement!
> Unless we want to convert NAN to some number when reading `req.ttl` and `req.grace`, I suggest we stick with -1 as the default value. I think we should print...
If anyone is interested how the adjustments look like for external vmods: * [re](https://gitlab.com/uplex/varnish/libvmod-re/-/merge_requests/5) * [pipe](https://gitlab.com/uplex/varnish/libvdfp-pipe/-/merge_requests/1) * [pESI](https://gitlab.com/uplex/varnish/libvdp-pesi/-/merge_requests/5)
> I feel that instead of breaking so much of the API to enable it for `*req.body` we could instead enhance the `vdp_ctx` and add a bunch of fields (`bo`,...
I have rebased, squashed the squashable commits and force-pushed .
Thank you for the review, @bsdphk . As [Dridi](https://github.com/varnishcache/varnish-cache/pull/4035#pullrequestreview-1808998464) and you gave similar feedback on this aspect, I will obviously respect your verdict. Yet one thing bothers me: If we...
> I really do not see what possible benefit a dedicated vdp_init_ctx would bring ? As I said: avoid code duplication. I think all a generic vdp init should be...
I'll prepare a diff to look at...
> FYI we are making progress on a limited initial support for trailers In case you missed it, we already had that in #2477. Based on the experience with this...