Martin Mauch
Martin Mauch
@dabruehl this was the change at that time, basically distinguishing between Spark 3.4.1 and 3.4.2: https://github.com/nightscape/spark-excel/pull/815/files I replaced this "folder-versioning" by the `@ifdef` macro recently though. Here's [an example](https://github.com/nightscape/spark-excel/blob/main/src/main/scala/dev/mauch/spark/excel/v2/ExcelDateTimeStringUtils.scala#L28-L45). I...
Ok, I'll close this for now 👍
Does this help? https://github.com/crealytics/spark-excel/pull/196#issuecomment-1376972780
This sounds related: https://learn.microsoft.com/en-us/answers/questions/1193968/py4j-security-py4jsecurityexception-databricks
Hmm, that would require a bigger refactoring then because we also need a HadoopConfiguration in the standard use case (even without reading sheet names): https://github.com/crealytics/spark-excel/blob/main/src/main/scala/com/crealytics/spark/excel/DefaultSource.scala#L38
Do you have any benchmarks that show the performance difference?
@jussisaurio actually this PR builds on #4038 and applies [a similar fix](https://github.com/tursodatabase/turso/pull/4042/files#diff-a19f0050a9ba6927eef4ddfbe0e0a09f137a71636080f15b3f630d5a000a48b9R2953-R2976) for the Rust bindings that the other PR [does for the SQLite C-bindings](https://github.com/tursodatabase/turso/pull/4038/files#diff-59186e12c0523053b2b2a30d04bb933ae67a1e12e9eade08956c5f409429a3b6R328-R338).
@jtroo amazing work!! 🎆 🎆 🎆 I'm just trying it out and it works very well so far. Here a few comments: - chordsv2 automatically inserts a space after each...
One minor issue worth noting: I switched back to chordsv2 for the time being (mostly because of the undesired chord expansions in zippy) and reverted the configuration so that there's...
It seems there's a small off-by-one bug in the smart-space implementation where it sometimes will delete all but the first typed character of the chord, leaving an output like `ssound`...