Natalie Klestrup Röijezon

icon indicating a website link https://natkr.com icon indicating an email [email protected]

icon company @stackabletech icon location Stockholm, Sweden

Results 288 comments of Natalie Klestrup Röijezon

fix: portforward connections

Hey, sorry. I'm honestly not quite comfortable reviewing this without a better way to test what's going on. I was working on that but did, indeed, end up forgetting about...

fix: portforward connections

I uploaded my repro to https://gitlab.com/teozkr/repros/-/tree/kube/portfwd-halfclose

fix: portforward connections

There are dozens of us!

fix: portforward connections

Thanks!

Namespace scoped access for `Controller.owns`

If you the NSes you want to watch are static then you could do something like: ```rust Controller::new(...) .owns(Api::::namespaced("ns1")) .owns(Api::::namespaced("ns2")) .owns(Api::::namespaced("ns...")) .run(...) ``` If you want to control which NSes...

Namespace scoped access for `Controller.owns`

I don't think the "full journey" will ever have direct first-class support in `Controller`. I think there might be value in exposing "also listen to this arbitrary `Stream`" as an...

Namespace scoped access for `Controller.owns`

Controller (Savage)

add general conditions::is_met helper to runtime::wait

Agreed with the general idea.. A few points though: 1. Can't we just use `DynamicObject` internally, rather than going through the reserialization dance? 2. IIRC `value` is a bool, not...

add general conditions::is_met helper to runtime::wait

Ahh, fair enough.

Controller<T> event duplication

This is to be expected, I'm afraid. The alternative would be pretty racy and unexpected (store the last-written `resourceVersion` somewhere?). IMO this also generally fits the expected behaviour. If you...