Natalie Klestrup Röijezon
Natalie Klestrup Röijezon
> That's kind of already broken. Not really. You won't get feature-is-required tags (which is slightly annoying), but `cargo doc` does answer "what is currently in my workspace, and how...
> and the links in the watcher example ends up pointing to: I have ran into this before! IIRC it should be fixable by adding an otherwise useless (heh…) `use...
Hi! While technically this shouldn't be too hard to implement into the watcher, it would break some assumptions that we make downstream. We basically have two options for implementing this:...
In the near term I expect simplest way to do this to be using `kube::Client::new` with a custom tower stack that delegates to `fetch` (via `gloo` or some other wrapper)....
Agreed that we need that too, and that creating a new version is the correct way to deal with this kind of breakage.
We already use `tokio::time::Instant` in most places because of the mocking, and the case of `backoff_reset_timer` looks like an oversight. :+1: from me.
To be clear, this is about the object being controlled, not the `CustomResourceDefinition` itself, right? Anyway... > Sometimes when I delete CRD right before reset/refresh of the watcher happens I...
> Do you mean inside the reconcile function I should query k8s API and check that there is still an object with given name/namespace? No. Generally you should not need...
> There is also an easy way to [convert to an ObjectReference via Resource](https://docs.rs/kube/latest/kube/api/trait.Resource.html#method.object_ref) (e.g. [usage](https://github.com/kube-rs/controller-rs/blob/deec3101cfd866316254aed2a44a7c3ee7102721/src/manager.rs#L63)). `ObjectRef` already covers this via `ObjectRef::from_obj`. > If we change our inteface to use...
Just a minor note (especially since this PR is fairly small), but please don't force-push to a PR that is already being reviewed. It makes it much harder to keep...