Niels Laute

Results 263 comments of Niels Laute

This is considered to be launching of a new application windows - not a dialog. Therefore, it should not close when pressing ESC? cc @crutkas

@crutkas Hmm true. It should be redesigned altogether. There are tens of accessibility issues with the current implementation.

@crutkas this is a default WinUI control... flag there?

If I understand correctly you want to show the unicode/other small description under the character and make it an option to show it? Would it make sense to add it...

@Aaron-Junker Apologies for the delay - pushed some changes that adds a bit of Fluent to the UI :) ![PowerAccentFluent](https://user-images.githubusercontent.com/9866362/201535210-4c63a3d9-cf27-4308-aaaf-7385e63b83ad.gif) (ModernWPF wasn't added yet.. so the blue is hardcoded -...

> @niels9001 > > 1. It would look better if the letters were centered. > 2. The letter selection flickers shortly > ![pt quickaccent 2](https://user-images.githubusercontent.com/58633848/201982833-9d68eb7b-7ff6-4074-9ad4-ebc354503a03.gif) > > 3. The same...

> @niels9001 > https://github.com/microsoft/PowerToys/blob/a1d5df23a8ca4995ee002718ef50782791a8a531/src/settings-ui/Settings.UI/Views/VideoConference.xaml#L31-L37 > This InfoBar has both an `IsOpen="True"` and an `IsVisible={Binding}` property, which I think is incorrect. > Why do we use **Visibility** on all InfoBars anyway,...

> When VS says a namespace is unneeded, shall I remove it? ![image](https://user-images.githubusercontent.com/65828559/282088228-35a60e9e-d79a-46ae-8bc8-833aa2eea3f6.png) > > Note: this one is consistent for every page in OobeViews Yeah, this can be removed...

> Should `"using:Microsoft.PowerToys.Settings.UI.Controls"` be a `xmlns:local=` or `xmlns:custom=`? ![image](https://user-images.githubusercontent.com/65828559/281913700-f3df0944-f53f-404f-a9e8-a9d752c88abb.png) Whatever works :) the 'local' or 'custom' part is up to the developer to determine. Here, 'controls' would make most sense?

> @niels9001 I was just looking at https://learn.microsoft.com/windows/uwp/xaml-platform/themeresource-markup-extension#when-and-how-to-use-themeresource-rather-than-staticresource and it looks like we should be using **ThemeResource** in a lot more places. It should be used for brushes, font properties...