Niels Laute
Niels Laute
This is considered to be launching of a new application windows - not a dialog. Therefore, it should not close when pressing ESC? cc @crutkas
@crutkas Hmm true. It should be redesigned altogether. There are tens of accessibility issues with the current implementation.
@crutkas this is a default WinUI control... flag there?
If I understand correctly you want to show the unicode/other small description under the character and make it an option to show it? Would it make sense to add it...
@Aaron-Junker Apologies for the delay - pushed some changes that adds a bit of Fluent to the UI :)  (ModernWPF wasn't added yet.. so the blue is hardcoded -...
> @niels9001 > > 1. It would look better if the letters were centered. > 2. The letter selection flickers shortly >  > > 3. The same...
> @niels9001 > https://github.com/microsoft/PowerToys/blob/a1d5df23a8ca4995ee002718ef50782791a8a531/src/settings-ui/Settings.UI/Views/VideoConference.xaml#L31-L37 > This InfoBar has both an `IsOpen="True"` and an `IsVisible={Binding}` property, which I think is incorrect. > Why do we use **Visibility** on all InfoBars anyway,...
> When VS says a namespace is unneeded, shall I remove it?  > > Note: this one is consistent for every page in OobeViews Yeah, this can be removed...
> Should `"using:Microsoft.PowerToys.Settings.UI.Controls"` be a `xmlns:local=` or `xmlns:custom=`?  Whatever works :) the 'local' or 'custom' part is up to the developer to determine. Here, 'controls' would make most sense?
> @niels9001 I was just looking at https://learn.microsoft.com/windows/uwp/xaml-platform/themeresource-markup-extension#when-and-how-to-use-themeresource-rather-than-staticresource and it looks like we should be using **ThemeResource** in a lot more places. It should be used for brushes, font properties...