PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Keyboard Manager]: 'Remap a key' Dialog is not getting closed using 'ESC' key.

Open DhananjaySaini007 opened this issue 3 years ago • 3 comments

Microsoft PowerToys version

0.45.0

Running as admin

  • [ ] Yes

Area(s) with issue?

Keyboard Manager

Steps to reproduce

Steps to reproduce Test Environment: OS: Windows 11 Version Dev App version: 0.45.0 App name: PowerToys Screen Reader: Narrator Tool: Accessibility Insight for Windows

Repro Steps:

  1. Launch 'PowerToys' application.
  2. In General tab, navigate to 'Keyboard Manager’ button and activate.
  3. Navigate to ‘Remap a key’ and activate it using enter/Space key.
  4. Now, Remap a key dialog box will appear.
  5.  Press 'ESC' key and Observe the issue.
    

Note : Same issue repro with Remap a shortcut.

User Impact: -> Priority 2 Keyboard user will face issue while navigating the app.

Guidelines Reference:- https://www.w3.org/TR/WCAG21/#multiple-ways

Attachments:

https://user-images.githubusercontent.com/91203131/134474753-5428fedf-1739-4be2-8409-30a8c794797c.mp4

PowerToys - 'Remap a key' Dialog is not getting closed using 'ESC' key

PowerToys - 'Remap a Shortcut' Dialog is not getting closed using 'ESC' key

✔️ Expected Behavior

When 'Esc' key pressed the 'Remap a key' dialog should get closed.

❌ Actual Behavior

When 'Esc' key pressed on the 'Remap a key' dialog is not getting closed.

Other Software

No response

DhananjaySaini007 avatar Sep 23 '21 09:09 DhananjaySaini007

This is considered to be launching of a new application windows - not a dialog. Therefore, it should not close when pressing ESC?

cc @crutkas

niels9001 avatar Sep 30 '21 13:09 niels9001

While under the hood, yes but i think the accessibility team is saying from an end user experience, the OK / cancel makes this basically into a dialog.

I think this is fair feedback.

crutkas avatar Sep 30 '21 16:09 crutkas

@crutkas Hmm true. It should be redesigned altogether. There are tens of accessibility issues with the current implementation.

niels9001 avatar Sep 30 '21 17:09 niels9001

This issue is still repro on version 0.76.2

Priyanshu073 avatar Jan 05 '24 05:01 Priyanshu073