nielash

Results 114 comments of nielash

Here's a revised version that addresses most of the feedback. The production code now uses `fs.AddConfig`. The one change I did not fully make is changing the _test_ code to...

Makes sense! Here's a new version with this changed.

> Even better would be to make `rclone sync` or other operations where it is the obvious intent actually do this cleanup automatically. For reference, see #6437 which was closed...

You make good points here, and it's hard to argue with them because in principle I agree with them. I think ultimately it is @ncw's decision, and if @ncw thinks...

> What do you think @nielash ? I might be misunderstanding what you mean, but personally I find the verbosity pretty helpful, especially for the integration tests. I don't have...

No real reason, other than that I just haven't gotten to it yet! (Those flags were added very recently.) There are a number of other rc params missing in addition...

Here's what I started if you'd like to run with it! https://github.com/nielash/rclone/commit/75c515f6ae7a400de74df8f6f8be43dde8eeb011

I wonder if the `TestSFTPRclone:` issue is related to the one identified on https://github.com/rclone/rclone/pull/7791? > And fix vfs cache encoding described in https://github.com/rclone/rclone/issues/7760 The problem is when we create and...

This was a real tricky one, but I think I finally figured out the `TestSFTPRclone:` issue. https://github.com/rclone/rclone/pull/7795/commits/15ff8ab01eacf3fe918e35a844e1b55d6f44a9f5

bisync should be respecting `--color`. Are you able to reproduce it outside of the tests? On the tests we deliberately hard-code `ALWAYS` so that the colors themselves are tested (any...