rclone icon indicating copy to clipboard operation
rclone copied to clipboard

Options recover and max-lock missing in cmd/bisync/rc.go

Open 0x3b0c opened this issue 1 year ago • 3 comments

Hi all,

I was trying to integrate rclone into my system by using it as rcd server. Noticed today there is no mappings for the options --recover and --max-lock on the api command sync/bisync

Checked cmd/bisync/rc.go and i'd say the implementation it's within my reach, just wondering if there is any particular reasons why some options are not mapped on the rc api?

Regards

0x3b0c avatar Apr 24 '24 12:04 0x3b0c

No real reason, other than that I just haven't gotten to it yet! (Those flags were added very recently.)

There are a number of other rc params missing in addition to those two, and I started a branch to add them as well as some logic to differentiate between required and optional params, but just haven't had the time to finish it yet.

Are you interested in working on it? I could send you what I started.

In any case, thank you for opening this issue -- it's a good reminder that this still needs to be done!

nielash avatar Apr 24 '24 23:04 nielash

Since we are planning to adopt rclone, yes I am interested to collaborate too

0x3b0c avatar Apr 25 '24 09:04 0x3b0c

Here's what I started if you'd like to run with it! https://github.com/nielash/rclone/commit/75c515f6ae7a400de74df8f6f8be43dde8eeb011

nielash avatar Apr 26 '24 01:04 nielash