Nicolas Noé

Results 55 comments of Nicolas Noé

In GitLab by @Tim-Hofmeester on Sep 23, 2020, 12:50 sorry missed that it was already here!

I prefer the simplest possible solution, avoiding confusion and making long-term maintenance easier, therefore **I vote for solution 1, and remove the separate fields**. While I agree it's possible to...

BTW, big :thumbsup: to the team for discussing such issues publicly on GitHub!

Indeed, I think a first useful step so I can help testing is to actually publish the theme at rubygems. I would proceed like that: - read generic instructions about...

I like having the flexibility of having customizable js/footer files (not sure which one is best), rather than support for a specific product. But if you add a bit of...

Also, it could be good to ensure the list follows the order of the core csv file.

Or an alternative: core_terms returns a tuple (order has no real meaning here), and provide another method (headers()? that return headers in order and with the ID!!)

That's interesting indeed, I was not aware of this possibility. It's almost a different projects (that uses this one behind the scenes) than a new feature, though. I'd be interested...

Also others: - [x] CoreRow.extensions - [ ] Row.raw_fields (also needs tests) - [x] Review and polish docstrings/API doc for Readers - [x] Review and polish docstrings/API doc for Rows...

In the process of converting all "line" mentions to "rows"