Nicolas Giraud

Results 107 comments of Nicolas Giraud

Duplicated of https://github.com/kalessil/phpinspectionsea/issues/1725

I don't speak Java and I never developped a PHPStorm pluggin, so I don't know how I could help in fixing this. What I think is something can be done...

Thank you @AllenJB I wasn't able to find #1639 when I wrote this issue. It wasn't in my intentions to create a duplicate. Nevertheless, original issue is more about the...

@AlexeyKosov That would depend on the configuration set on PHPStorm Inspections about "prefer decode into array / prefer decode into object" choice. But yes, if the tool could suggest it...

@CRC-Mismatch You're right: every validation that uses arguments without taking their names into account is a possible false-positive. IMO, as `[EA] Please consider taking advantage of JSON_THROW_ON_ERROR flag for this...

This comes with a special case to handle: if there is a use of an `array_merge` already with array unpacking operator as arugments, then you'll not capable of re-using over...

I think this inspection (Code Style -> Self class referencing) is not applied here, as this is not expected to be applied. The inspection description clearly says it supports: *...

@rskuipers If PHPStan is already taking care about warning developpers to use assertions instead of assumptions, then you could deprecate this tool and redirect to PHPStan. But if not, then...

> Did I disregard this tool's value too quickly? I wouldn't say "too quickly" as it seems you started to work on this long time ago... A colleague of mine...

This way to exclude some snippets for valid reasons is much better than using the configuration file, so thank you very much for this implementation. Are you also working on...