nicolas-duteil-nova
nicolas-duteil-nova
> Since closefrom() is supported in all recent systems, I don't see the advantage in having a complicated fallback using /proc. So I suggest to remove the complicated fallback and...
What about the last version which uses a separate function to compute the max number of file descriptors and close any descriptor >3 under linux @bellard ?
> > What about the last version which uses a separate function to compute the max number of file descriptors and close any descriptor >3 under linux @bellard ? >...
> Interesting approach with a Makefile test run on the fly. > > I would probably create a subdirectory `compat` for such source files to avoid clutter in the main...
> There is still a problem: you should avoid closing the handle for the directory structure: > > ``` > if (fd > 2 && fd != dirfd(dir)) { >...
@chqrlie : can you approve the workflow ?
Can we merge this one or does it need extra refactoring ? /cc @chqrlie
@chqrlie : can we merge this one ?
> > @chqrlie : can we merge this one ? > > Sorry for the lack of responsiveness, a simpler approach seems advisable, see my proposed changes. I completely agree...
> > What would be the adverse side effect of merging this PR @chqrlie ? > > Well it adds lots of extra code as a partial solution for very...