Nico Epp

Results 7 comments of Nico Epp

Are the `socket_options` set correctly from `HTTPConnection.default_socket_options`? I'm looking at the following code: ```python class HTTPConnection(_HTTPConnection): # ... #: Disable Nagle's algorithm by default. #: ``[(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)]`` default_socket_options: typing.ClassVar[connection._TYPE_SOCKET_OPTIONS]...

Setting the default options should have worked before this commit: https://github.com/urllib3/urllib3/commit/287052a16a59bcaba5772387de36fa9a49eb8378 Something like this should fix it: ```python def __init__( self, # ... socket_options: None | (connection._TYPE_SOCKET_OPTIONS) = HTTPConnection.default_socket_options, #...

@sethmlarson Thoughts? I'd be happy to create a PR addressing this issue but would need some guidance.

Thanks for you feedback @sarayourfriend! I pushed some commits and I'm running the linter locally now but I gotta go now. I will hopefully push the linting changes tonight.

I'm playing around with the idea to log the full result of `get_batch_data` as suggested by @stacimc. I'm running into problems logging the full list of dictionaries of the returned...

Here is the full log file (from the screenshot) for better reference: [dag_id=smk_workflow_run_id=manual__2024-04-10T20_03_28.log](https://github.com/WordPress/openverse/files/14937378/dag_id.smk_workflow_run_id.manual__2024-04-10T20_03_28.log)

Ok. Thanks for the feedback. I'm only logging the first 5 dictionaries of the batch for now. I also pushed a commit making the verbose logging always controlled by the...