Nicolas Abram

Looks possibly similar to https://github.com/rust-lang/cargo/issues/1032

From a cursory look, it seems to have 5 unsafe blocks: 1) [unaligned reads to turn a &[u8] into a u64](https://gitlab.redox-os.org/redox-os/seahash/-/blob/master/src/helper.rs#L3-54) This looks fine to me Maybe the big unsafe...

There seems to be quite a bit of unsafe in here. Some low hanging fruit seems to be in https://github.com/m4b/goblin/blob/master/src/pe/data_directories.rs#L38-L97 . I believe these unsafe get_unchecked's to be completely unnecessary....

I just skimmed the unsafes in the master branch. There's a mem::uninitialized in a bench, and there's 3 instances of setting a vec's len and then making a slice from...

I mentioned here (https://github.com/rust-secure-code/safety-dance/issues/4#issuecomment-523706699) that claxon seems to do something similar (https://github.com/ruuda/claxon/blob/cd82be35f413940ba446d2a19f10d74b86466487/src/metadata.rs#L459-L461)

The dropbox link in the reddit thread seems dead (For the thesis you mention). Do you have any other uploads of it?

This issue is resolved right? It's still open cc @JakubOnderka , @hroi

`VCPKGRS_TRIPLET_OVERRIDE` does not exist, it was hypothetical

@LoganDark I tried building the stackblur `fruit` example on windows (msvc target) and it seems to work alright (10 out of 10 times it finished succesfully and the flamegraph looks...

Would https://docs.microsoft.com/en-us/windows/win32/memory/address-windowing-extensions (Specifically https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-mapuserphysicalpages?redirectedfrom=MSDN to manually map physical pages), and https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/ntddk/nf-ntddk-mmgetphysicaladdress (To get physical pages (I'm assuming it can be done from the address)) be enough for getting started on...