Joas Schilling

> Removed unnecessary JS logic for keyboard navigation (apparently adding !important always activates the focus-visible when navigating with the keyboard) Should be fixed now that the server doesn't simply touch...

Sure also fine to have it more often.

Yeah still missing

Can you also make dark mode screenshots? Would like to see how that turns out.

Hover focus should be black (bright in dark mode!) for now I think (as it is in several other places) and especially since this PR is only supposed to fix...

So the one thing I think needs fixing in the button component is the font color of the secondary button should depend on the background color not the primary color:...

But after this there is a lot of work necessary to fix the element colors in the server: ```diff diff --git a/apps/theming/css/theming.scss b/apps/theming/css/theming.scss index 52337d2105..3b84b5e52b 100644 --- a/apps/theming/css/theming.scss +++ b/apps/theming/css/theming.scss...

So I created a testing grid with different colors in dark and bright  I thought we always had a white and a black threshhold. But seems...

So the problem is actually that the thresholding we have: https://github.com/nextcloud/server/blob/e3a12b348206adcfbfb0fbc8435ba91240ac2b0a/apps/theming/lib/Util.php#L82-L96 Is missing from: https://github.com/nextcloud/server/blob/760db78dbac8ac81f58dd0f2797b7d76fb0af239/apps/theming/lib/ThemingDefaults.php#L342 I mean it is there, but it falls back to "bright mode" as the dark...

@PVince81 any opinion on first and second Error?